This repository has been archived by the owner. It is now read-only.
Hackathon changes: rebuild support, code cleanup, simpler tests, install process. #3
Merged
+1,132
−725
Conversation
Makefile still relinks for some obscure reason, nothing's breaking though.
Previously, install would fail because we invoked node-gyp before nan would be installed.
Orders and dependencies are not the same thing.
fix typos along the way
binding.gyp: adds Mac OSX compatibility
Avoids rebuilding libraries if already present
- tests can be run via "npm test" - tests do not generate output - tests fail with process exit status 1 - README.md explains how to run the tests
adds back previously merged commits, rebased against master
Work on both os: Mac and Linux
fix(Makefile): doesn't relink anymore with npm install
removes `npm install node-gyp` on every `npm install`
reconstruct: adds support for reconstructing 1 missing fragment
|
close #2 |
vrancurel
added a commit
that referenced
this issue
Sep 28, 2015
Hackathon changes: rebuild support, code cleanup, simpler tests, install process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hello team,
This PR:
rebuildsupport of missing fragments.I would have liked to make a lot of small PRs, but you have had to do a lot of rebases once the hackathon was over, so I chose to make one large PR.
Tests can be run with
./run_tests.bash.Feedback is appreciated👍
Conrad