Hackathon changes: rebuild support, code cleanup, simpler tests, install process. #3

conradkleinespel · 2015-07-21T14:45:07Z

Hello team,

This PR:

uses full OOP so we don't need special structs to free memory anymore,
updates the tests corresponding to the code that changed, makes then easier to run and documents them,
adds @mzap 's changes to make the installation process easier,
adds rebuild support of missing fragments.

I would have liked to make a lot of small PRs, but you have had to do a lot of rebases once the hackathon was over, so I chose to make one large PR.

Tests can be run with ./run_tests.bash.

Feedback is appreciated 👍

Conrad

Makefile still relinks for some obscure reason, nothing's breaking though.

Previously, install would fail because we invoked node-gyp before nan would be installed.

Orders and dependencies are not the same thing.

fix typos along the way

binding.gyp: adds Mac OSX compatibility

Avoids rebuilding libraries if already present

- tests can be run via "npm test" - tests do not generate output - tests fail with process exit status 1 - README.md explains how to run the tests

adds back previously merged commits, rebased against master

Work on both os: Mac and Linux

fix(Makefile): doesn't relink anymore with npm install

removes `npm install node-gyp` on every `npm install`

reconstruct: adds support for reconstructing 1 missing fragment

vrancurel · 2015-09-28T12:57:45Z

close #2

Hackathon changes: rebuild support, code cleanup, simpler tests, install process.

Michael Z added 4 commits Jul 13, 2015

integration(npm): streamline installation process

b06a547

Makefile still relinks for some obscure reason, nothing's breaking though.

fix(npm): work with non-existing node_modules dir

de2a873

Previously, install would fail because we invoked node-gyp before nan would be installed.

fix(npm): makefile doesn't relink anymore

f1dfec6

Orders and dependencies are not the same thing.

docs(README): describe install process

6e8ac0b

fix typos along the way

conradkleinespel changed the title ~~Fixes compilation errors~~ Full OOP & correspoding test updates Jul 22, 2015

conradkleinespel and others added 16 commits Jul 22, 2015

binding.gyp: adds Mac OSX compatibility

59f9a26

Merge pull request #1 from conradkleinespel/mzap/streamlining-patch

ecb0407

binding.gyp: adds Mac OSX compatibility

avoids rebuilding libraries if already present

c1440f6

Merge pull request #1 from conradkleinespel/install-1

33b36bc

Avoids rebuilding libraries if already present

fixes compilation errors

c8bada5

adds header include protection;

d367e18

adds comments

7d6a57e

simplifies testing

50ccaec

- tests can be run via "npm test" - tests do not generate output - tests fail with process exit status 1 - README.md explains how to run the tests

Merge pull request #2 from conradkleinespel/rebase-master

a818ac6

adds back previously merged commits, rebased against master

fix(Makefile): doesn't relink anymore with npm install

018b596

Work on both os: Mac and Linux

Merge pull request #4 from jagu-sayan/patch-1

8b48158

fix(Makefile): doesn't relink anymore with npm install

removes npm install node-gyp on every npm install

a7591bb

Merge pull request #5 from conradkleinespel/mffix

dcaf4f7

removes `npm install node-gyp` on every `npm install`

reconstruct: adds support for reconstructing 1 missing fragment

68e0d1d

reconstruct: adds support for reconstructing multiple fragments

6ff84e0

Merge pull request #6 from conradkleinespel/rebuild

d25e685

reconstruct: adds support for reconstructing 1 missing fragment

conradkleinespel changed the title ~~Full OOP & correspoding test updates~~ Hackathon changes: rebuild support, code cleanup, simpler tests, install process. Jul 31, 2015

vrancurel added a commit that referenced this issue Sep 28, 2015

Merge pull request #3 from conradkleinespel/rebase-master

46e4733

Hackathon changes: rebuild support, code cleanup, simpler tests, install process.

vrancurel merged commit 46e4733 into scality:master Sep 28, 2015

Hackathon changes: rebuild support, code cleanup, simpler tests, install process. #3

Hackathon changes: rebuild support, code cleanup, simpler tests, install process. #3

conradkleinespel commented Jul 21, 2015

vrancurel commented Sep 28, 2015

Hackathon changes: rebuild support, code cleanup, simpler tests, install process. #3

Hackathon changes: rebuild support, code cleanup, simpler tests, install process. #3

Conversation

conradkleinespel commented Jul 21, 2015

vrancurel commented Sep 28, 2015